Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable superuser password #306

Merged
merged 6 commits into from
Dec 20, 2024
Merged

feat: configurable superuser password #306

merged 6 commits into from
Dec 20, 2024

Conversation

fanyang01
Copy link
Collaborator

@fanyang01 fanyang01 commented Dec 20, 2024

Resolves #305

This PR adds the --superuser-password CLI flag and the SUPERUSER_PASSWORD Docker environment variable to enable configurable superuser password.

@fanyang01 fanyang01 requested a review from Copilot December 20, 2024 10:57

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • devtools/replica-setup-postgres/replica_setup.sh: Language not supported
  • docker/entrypoint.sh: Language not supported
  • .github/workflows/clients-compatibility.yml: Evaluated as low risk
  • README.md: Evaluated as low risk
Comments suppressed due to low confidence (1)

pgtest/server.go:83

  • Verify that the DSN string is accurate and reflects the intended behavior, especially with the 'postgres' user.
dsn := fmt.Sprintf("postgres://postgres:@127.0.0.1:%d/memory", port)
@fanyang01 fanyang01 merged commit be912e8 into main Dec 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the root password configurable
1 participant