feat: add support for managing multiple databases #307
+432
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-multiple-databases # Conflicts: # pgserver/server.go
NoyException
force-pushed
the
noy/feat-multiple-databases
branch
from
65100a7 to
041f248
Compare
TianyuZhang1214
requested changes
Dec 23, 2024
fanyang01
reviewed
Dec 23, 2024
TianyuZhang1214
requested changes
Dec 24, 2024
| @@ -12,6 +12,9 @@ type InternalTable struct { | |||
| } | |||
|
|
|||
| func (it *InternalTable) QualifiedName() string { | |||
| //if it.Schema == "__sys__" { | |||
There was a problem hiding this comment.
remove unnecessary comment here
| if dbFile == "" { | ||
| // in-memory mode, mainly for testing | ||
| name = "memory" | ||
| func NewDBProvider(defaultTimeZone, dataDir, defaultDB string) (prov *DatabaseProvider, err error) { |
There was a problem hiding this comment.
It seems we don't have strategy to scan all .db files under the data dir and attach them to current datbase?
| connector *duckdb.Connector | ||
| storage *stdsql.DB | ||
| catalogName string | ||
| pool *ConnectionPool // TODO(Noy): Merge into the provider |
There was a problem hiding this comment.
It's better to make it an issue of refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.