Skip to content

Conversation

@percevalw
Copy link
Member

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation.

@percevalw percevalw force-pushed the fail-draft-string-types branch from 4144a4b to 6fd8958 Compare January 21, 2026 15:28
@github-actions
Copy link

Coverage Report

NameStmtsMiss∆ MissCover
TOTAL107618098.33%
Files without new missing coverage
NameStmtsMiss∆ MissCover
confit/utils/settings.py

Was already missing at lines 10-12

         return bool(loads(value))
-     except Exception:
-         return True

112081.82%
confit/registry.py

Was already missing at line 132

         if name is None and hasattr(e.model, "type_"):
-             name = e.model.type_.__module__ + "." + e.model.type_.__qualname__
         e = ConfitValidationError(
Was already missing at lines 545-550
         """
-         entrypoints = importlib_metadata.entry_points()
  ...
-             return entrypoints.get(self.entry_point_namespace, [])
Was already missing at line 575
                 if catalogue.check_exists(*path):
-                     return catalogue._get(path)
                 elif from_entry_point:
Was already missing at line 577
                 elif from_entry_point:
-                     return from_entry_point
             if not catalogue.check_exists(*path):
Was already missing at line 584
                 )
-             return catalogue._get(path)

2308096.52%
confit/config.py

Was already missing at line 146

         if resolve:
-             return config.resolve(registry=registry)
Was already missing at line 367
                     return local_names[parts] + ("." if path.endswith(":") else "")
-                 except KeyError:
                     raise KeyError(path)
Was already missing at line 412
             if not deep and len(loc) > 1:
-                 return obj
Was already missing at line 500
                 return
-             current[path] = val
Was already missing at line 541
                     ):
-                         old[key] = new_val
                     else:
Was already missing at line 577
             elif isinstance(obj, list):
-                 return [rec(v) for v in obj]
             elif isinstance(obj, tuple):
Was already missing at line 579
             elif isinstance(obj, tuple):
-                 return tuple(rec(v) for v in obj)
             elif isinstance(obj, Reference):
Was already missing at line 628
     if isinstance(config_paths, Path):
-         config_paths = [config_paths]

3068097.39%

10 files skipped due to complete coverage.

Coverage success: total of 98.33% is above 98.32% 🎉

@percevalw percevalw merged commit ce0efda into main Jan 21, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants