Use api3 as DOCKERHUB_USERNAME in docker-build CI workflow#2035
Merged
Use api3 as DOCKERHUB_USERNAME in docker-build CI workflow#2035
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2034. Note that I didn't hardcode the variable everywhere- there are a a few publishing-related places below that retain it. The reason being that we've sometimes needed to push images to forks for testing and hardcoding
api3wouldn't be ideal, whereas hardcoding it in the CI workflow makes sense.Other note: the CI docker build step is expected to fail because no changesets that affect packages have been added since the last release (see e.g. #1585 (comment))
airnode/package.json
Line 55 in 5b5e8c3
airnode/docker/scripts/docker.ts
Lines 35 to 44 in 5b5e8c3
and
airnode/docker/README.md
Lines 274 to 289 in 5b5e8c3