Skip to content

Tamera: green > indigo root colors - DO NOT MERGE FOR NOW#149

Merged
bbenligiray merged 11 commits intomainfrom
t-colors
Mar 3, 2025
Merged

Tamera: green > indigo root colors - DO NOT MERGE FOR NOW#149
bbenligiray merged 11 commits intomainfrom
t-colors

Conversation

@wkande
Copy link
Member

@wkande wkande commented Jan 12, 2025

Tamera wants to change the green color to an indigo scheme. This PR is get a live preview for her to view.

@wkande wkande requested a review from T9991 January 12, 2025 14:52
@wkande wkande self-assigned this Jan 12, 2025
@github-actions
Copy link

github-actions bot commented Jan 12, 2025

Visit the preview URL for this PR (updated for commit daab564):

https://oev-docs--pr149-t-colors-z4p19c3i.web.app

(expires Fri, 07 Mar 2025 14:58:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6915b094b5ba83fde754632ba50c1ee9406d433f

@wkande wkande marked this pull request as draft January 26, 2025 15:02
@peterjurco
Copy link
Contributor

@wkande Tamara gave me the CSS file with all the updated colors. I have added it here.

@T9991
Copy link

T9991 commented Feb 14, 2025

We're switching the gray-soft colors- will get back to you on what value it should be.

Question about this:
image

Is it easy to override? It's just that the comments within the codeblocks are slightly too dark.

@peterjurco
Copy link
Contributor

@T9991

Is it easy to override?

Yes, it's easy to override. Either change the value of the --shiki-light and --shiki-dark or override the .vp-code span class with our custom color.

@T9991
Copy link

T9991 commented Feb 17, 2025

  1. Hm.. I think it's responsible for the gray color here:
    image

But I think it's also for all the code colors. Not sure if you can override just that single one. If so, it should be #757E8A to meet accessibility standards

  1. I don't understand where this code-bg color is coming from
    image

  2. I think the backgrounds behind these tips is missing
    image

  3. Minor thing, the copyright in the footer needs to be to the "API3 Foundation" instead of just "API3"

If we can solve these things, then would be good to go

@peterjurco
Copy link
Contributor

@T9991

  1. The comment color in the code block updated for the dark theme to #757E8A
  2. It comes from --vp-code-bg which is set to #36454f;. Do you want to change it?
  3. It comes from --vp-custom-block-info-bg which is set to --vp-c-gray-soft which is set to rgba(10, 16, 82, 0.1). Do you want to change it?
  4. Updated

@T9991
Copy link

T9991 commented Feb 19, 2025

Final color for --vp-c-gray-soft: rgba(142, 155, 178, .16)

@T9991
Copy link

T9991 commented Feb 19, 2025

Light and dark logos
Api3-Logo-Symbol-Dark
Api3-Logo-Symbol-Light

@peterjurco peterjurco marked this pull request as ready for review February 20, 2025 12:29
@peterjurco
Copy link
Contributor

Both background color and new logos updated

@T9991 are we ready for release?

@T9991
Copy link

T9991 commented Feb 20, 2025

Absolute last change- the same color but on light is just too light. Change rgba(242, 244, 255, 0.8); to rbga(142, 155, 178, .1)

@peterjurco
Copy link
Contributor

Done ✅

T wanted to change this color
@bbenligiray bbenligiray merged commit f4295be into main Mar 3, 2025
3 checks passed
@bbenligiray bbenligiray deleted the t-colors branch March 3, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants