-
Notifications
You must be signed in to change notification settings - Fork 4
Elaborate on OEV Rewards #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3b83051
Remove unnecessary quotation mark
bbenligiray 9a52c45
Refer to the screenshot
bbenligiray 0062c07
Move the screenshot next to the reference
bbenligiray 2710629
Correct wording
bbenligiray 2c8b9b7
Improve Google search link
bbenligiray f9b1132
Cross-link
bbenligiray 491e0b6
Rewrite OEV Rewards sections to elaborate on the revenue breakdown
bbenligiray 76a8453
Fix hyperlink
bbenligiray 970c5e7
Merge branch 'main' into elaborate-oev-rewards
bbenligiray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd put this section above "How to get onboard" because majority of users will come here to remind themselves how OEV Rewards work.
Alternative would be to move the "How to get onboard" section into separate page, and rename this "Getting paid" to "Overview".
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first-class citizen here is the potential OEV user. They didn't click "Apply for OEV Rewards", they clicked "Read more" and came here. There may be two reasons for that
That's why index.md starts with a small marketing pitch and then reassures them that the onboarding is a limited number of concrete steps (and not TG groupchat hell).
The OEV Rewards breakdown is only an implementation detail that just needs to be in the docs somewhere. If something is to be migrated to its own page, it's that (but right now it would be a too short of a page).