Conversation
mcoetzee
left a comment
There was a problem hiding this comment.
We want to upgrade pnpm to v10 along with using the shared Renovate preset. pnpm v10 helps to prevent supply chain attacks. To do that we'll need to update package.json:
"packageManager": "pnpm@10.26.2",
"engines": {
"pnpm": "^10.26.2"
},and to add a pnpm-workspace.yaml:
# See: https://pnpm.io/supply-chain-security
blockExoticSubdeps: true
minimumReleaseAge: 20160 # 14 days (keep in sync with Renovate config)
package.json
Outdated
| "engines": { | ||
| "pnpm": "^10.26.2" | ||
| }, |
There was a problem hiding this comment.
Added, but I think engines will cause a problem for Airnode. Is there a strong reason it's needed here?
There was a problem hiding this comment.
Hmm good point 👍. Seeing as this package.json gets published to NPM it probably doesn't make sense to set the "pnpm" version like this. I think lets remove it.
FYI it's mostly a sanity check for non-corepack users/contributors of a repo. E.g. if someone wants to contribute to the repo but isn't using a pnpm version that falls into this range, then pnpm install would fail.
Relates to https://github.com/api3dao/tasks/issues/1777