Skip operation effect validation for endpoints using Skip API call#457
Merged
Skip operation effect validation for endpoints using Skip API call#457
Skip API call#457Conversation
Siegrift
approved these changes
Apr 28, 2025
| if (templates[templateId] === undefined) { | ||
| ctx.addIssue({ | ||
| code: z.ZodIssueCode.custom, | ||
| message: `Template ID "${templateId}" is not defined in the config.templates object`, |
Collaborator
There was a problem hiding this comment.
nit:
Suggested change
| message: `Template ID "${templateId}" is not defined in the config.templates object`, | |
| message: `Template ID "${templateId}" is not defined`, |
if we ever refactor the config it can go stale.
Contributor
Author
There was a problem hiding this comment.
if we ever refactor the config it can go stale.
You're right but current version clearly points where the issue arises. I'd recommend to keep it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #456
For visibility: @metobom