feat: upgrade to openresty-1.25.3.1 #83
Conversation
…unner.patch" This reverts commit 11d4790.
|
|
||
| - name: Install | ||
| run: | | ||
| wget https://raw.githubusercontent.com/api7/apisix-build-tools/master/build-apisix-base.sh | ||
| wget https://raw.githubusercontent.com/zll600/apisix-build-tools/upgrade_openresty-1.25.3.1/build-apisix-base.sh |
There was a problem hiding this comment.
remember to revert this change
There was a problem hiding this comment.
this project can not depend apisix-build-tools
apisix-build-tools base on apisix-nginx-module
| @@ -210,6 +210,6 @@ exited | |||
| } | |||
| --- response_body | |||
| ok | |||
| --- shutdown_error_log | |||
| --- error_log | |||
There was a problem hiding this comment.
Why do you change this?
The --- shutdown_error_log section is used for checking the error logs generated during nginx exit.
The --- error_log to test normal error logs
I think they are for different purpose
There was a problem hiding this comment.
I found that log appears in error_log, but not in shutdown_error_log.
I also confirmed this by modifying the source code of test-nginx.
There was a problem hiding this comment.
we need to merge this PR first.
this change seems acceptable
@monkeyDluffy6017 if you have different though, you can create new issue or PR to fix it
monkeyDluffy6017
changed the title
There was a problem hiding this comment.
add a todo issue: https://github.com/api7/apisix-nginx-module/pull/83/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR41
we will revert this line after we merge api7/apisix-build-tools#367
|
|
||
| - name: Install | ||
| run: | | ||
| wget https://raw.githubusercontent.com/api7/apisix-build-tools/master/build-apisix-base.sh | ||
| wget https://raw.githubusercontent.com/zll600/apisix-build-tools/upgrade_openresty-1.25.3.1/build-apisix-base.sh |
There was a problem hiding this comment.
this project can not depend apisix-build-tools
apisix-build-tools base on apisix-nginx-module
| @@ -210,6 +210,6 @@ exited | |||
| } | |||
| --- response_body | |||
| ok | |||
| --- shutdown_error_log | |||
| --- error_log | |||
There was a problem hiding this comment.
we need to merge this PR first.
this change seems acceptable
@monkeyDluffy6017 if you have different though, you can create new issue or PR to fix it
No description provided.