fix: give more priority to longer routes #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/apisix#9366
Explanation:
when creating different routes that have a common prefix but are differentiated with a parameter, route matching becomes dependent on the registration order.
Consider the case:
uri for route_a:
/api/:version/test/api/projects/:project_id/clusters/:cluster_id/nodes/?uri for route_b:
/api/:version/test/*subpathpath to be matched:
/api/v4/test/api/projects/saas/clusters/123/nodes/Theoretically, the above path should match
route_abut due to the bug ifroute_bis registered beforeroute_a,route_bwill be matched