Narrow layout tweaks #98
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjust `CodeSwitcher` component padding by adding `pb-1` to ensure consistent spacing. - Update `GitHubHeader` component to include responsive styles for medium-sized screens with `md:mx-auto`, `md:max-w-3xl`, and `md:px-0`. - Modify the anchor positioning in the `HeadingLinks` component by changing the left offset to `-left-6` for better alignment. - Reduce the `WIDE_SCREEN_WIDTH` in the configuration from 1710 to 1664 for improved responsiveness. - Apply a maximum width of 3xl and center alignment on medium-sized screens for elements like paragraphs, lists, tables, and blockquotes. - Ensure headings (`h1`, `h2`, `h3`, and `h4`) are also centered with appropriate padding adjustments on medium-sized screens.
Member
|
I don't think this new version looks better than the current one. Some of the layouts look more like a bug than feature. I'd keep it as is. cc @mtrunkat 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new narrow layout based on the request by @mtrunkat in #18. Marek, please try this branch and let me know if it works better for you now.
Detailed changelog:
CodeSwitchercomponent padding by addingpb-1to ensure consistent spacing.GitHubHeadercomponent to include responsive styles for medium-sized screens withmd:mx-auto,md:max-w-3xl, andmd:px-0.HeadingLinkscomponent by changing the left offset to-left-6for better alignment.WIDE_SCREEN_WIDTHin the configuration from1710to1664for improved responsiveness.3xland center alignment on medium-sized screens for elements like paragraphs, lists, tables, and blockquotes.h1,h2,h3, andh4) are also centered with appropriate padding adjustments on medium-sized screens.Fixes #18
/c @netmilk – can you please try this? There are a couple of highly visible changes.