Skip to content

chore: Use inherit instead of RemainingTime #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pijukatel merged 1 commit into from
Dec 9, 2025
Merged

chore: Use inherit instead of RemainingTime #701

Pijukatel merged 1 commit into from
Dec 9, 2025

Conversation

@Pijukatel
Copy link
Contributor

@Pijukatel Pijukatel commented Dec 8, 2025 •
edited
Loading

  • Use inherit literal instead of RemainingTime
  • Mark usage of RemainingTime as deprecated
  • Add inherit timeout option to Actor.call_task

To be aligned with JS implementation: apify/apify-sdk-js#518 (comment)

@github-actions github-actions bot added this to the 129th sprint - Tooling team milestone Dec 8, 2025
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Dec 8, 2025
@Pijukatel
Copy link
Contributor Author

Pijukatel commented Dec 8, 2025

To be fully removed in version 4: #697

@Pijukatel Pijukatel requested a review from vdusek December 8, 2025 12:28
@Pijukatel Pijukatel force-pushed the deprecate-RemainingTime branch from 6b012e9 to 5af3ff6 Compare December 8, 2025 15:07
@Pijukatel Pijukatel marked this pull request as ready for review December 8, 2025 15:39
vdusek
vdusek approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just please make sure we either keep #697 open, or create a new issue with the 4.0 milestone - so we don't forget to remove the deprecations.

@Pijukatel Pijukatel merged commit e7e5137 into master Dec 9, 2025
48 of 49 checks passed
@Pijukatel Pijukatel deleted the deprecate-RemainingTime branch December 9, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdusek vdusek vdusek approved these changes

Assignees

@Pijukatel Pijukatel

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Milestone

129th sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

3 participants

@Pijukatel @vdusek