chore: Fix flaky test_actor_handles_migrating_event_correctly
#704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-tooling
Contributor
Author
|
Stress tested 1000x times in CI |
vdusek
approved these changes
Dec 8, 2025
vdusek
reviewed
Dec 8, 2025
| await asyncio.sleep(1) | ||
|
|
||
| assert len(persist_state_events_data) >= 3 | ||
| assert len(persist_state_events_data) >= 2 |
Contributor
There was a problem hiding this comment.
It is enough to check the persist state event we send manually and the Crawler final one.
Could we just please add a comment describing this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Do run run persist state event every 500 ms to prevent flakiness. It is enough to check the persist state event we send manually and the Crawler final one.
Issues:
Closes: #703