Skip to content

Conversation

@vdusek
Copy link
Contributor

@vdusek vdusek commented Dec 12, 2025

@vdusek vdusek added this to the 129th sprint - Tooling team milestone Dec 12, 2025
@vdusek vdusek self-assigned this Dec 12, 2025
@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Dec 12, 2025
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.00%. Comparing base (ea0a3c0) to head (2b5bc49).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #709   +/-   ##
=======================================
  Coverage   82.00%   82.00%           
=======================================
  Files          46       46           
  Lines        2679     2679           
=======================================
  Hits         2197     2197           
  Misses        482      482           
Flag Coverage Δ
integration 56.14% <ø> (ø)
unit 67.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek force-pushed the fix-failing-integration-tests branch from 871397a to ce3e726 Compare December 13, 2025 17:48
@vdusek vdusek force-pushed the fix-failing-integration-tests branch from ce3e726 to 73c2ce3 Compare December 15, 2025 12:26
@vdusek vdusek changed the title tests: Fix failing integration tests [WIP] tests: Fix Actor logging integration test Dec 15, 2025
@vdusek vdusek marked this pull request as ready for review December 15, 2025 13:43
@vdusek vdusek changed the title tests: Fix Actor logging integration test test: Fix Actor logging integration test Dec 15, 2025
@vdusek vdusek requested a review from janbuchar December 15, 2025 13:45
full_log = '\n'.join(run_log_lines)

# Verify expected log messages are present (order-independent checks)
assert '[apify] DEBUG Debug message' in full_log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will allow this. Honestly, I'd be fine if you just removed this test 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the logging can be problematic due to our custom configuration in Actor -> https://github.com/apify/apify-sdk-python/blob/master/src/apify/_actor.py#L169-L172 . We already had cases with log statements before configure_logging, which were supposed to log info messages, but it wasn't working, and this went unnoticed for a long time. Because of that, I would prefer to keep this test :).

@vdusek vdusek merged commit b1a8aed into master Dec 15, 2025
28 of 31 checks passed
@vdusek vdusek deleted the fix-failing-integration-tests branch December 15, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants