feat: Add keep_alive flag to crawler.__init__
#921
+58
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pijukatel
added
enhancement
github-actions
bot
added
the
tested
Add test for this usecase.
janbuchar
reviewed
Jan 20, 2025
Comment on lines
1129
to
1136
| @pytest.mark.parametrize( | ||
| ('keep_alive', 'max_requests_per_crawl', 'should_process_added_request'), | ||
| [ | ||
| pytest.param(True, 1, True, id='keep_alive'), | ||
| pytest.param(True, 0, False, id='keep_alive, but max_requests_per_crawl achieved'), | ||
| pytest.param(False, 1, False, id='Crawler without keep_alive (default)'), | ||
| ], | ||
| ) |
There was a problem hiding this comment.
Could you add a test case with max_requests_per_crawl > 1?
janbuchar
reviewed
Jan 20, 2025
janbuchar
approved these changes
Jan 20, 2025
| crawler_run_task = asyncio.create_task(crawler.run()) | ||
|
|
||
| # Give some time to crawler to finish(or be in keep_alive state) and add new request. | ||
| await asyncio.sleep(1) |
There was a problem hiding this comment.
Isn't 1 second like... a lot?
There was a problem hiding this comment.
Well any time related test is tricky if there is no event to wait for. How do I make sure that the crawler is alive because keep_alive = True and not just because it is randomly slow and takes time to shut down?
I could wrap basic_crawler.__is_finished_function in some mock and wait until it is called at least once, instead of wait time. It will be faster test, but it will leak implementation. Do you prefer that or some other option?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add keep_alive flag to
crawler.__init__If True, this flag will keep crawler alive even when there are no more requests in queue. Crawler is then waiting for more requests to be added or to be explicitly stopped by
crawler.stop().Add test.
Issues
keep_aliveflag toBasicCrawler#891