Aggregate cacheability information from access results #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that cacheability information bubbles up from previously evaluated access results instead of just get lost.
|
Just spotted this when I took a look at the source code. Do we also need an issue for this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #1061 +/- ##
=========================================
Coverage 44.37% 44.37%
Complexity 3041 3041
=========================================
Files 342 342
Lines 11111 11111
=========================================
Hits 4931 4931
Misses 6180 6180 |
|
All failures look unrelated. |
Hi @mxr576 Thanks! |
Hi @mxr576 |
|
Opened #1062. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that cacheability information bubbles up from previously evaluated access results instead of just get lost.
Closes #1062.