Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.3 version added #1063

Open
wants to merge 7 commits into
base: 3.x
Choose a base branch
from
Open

PHP 8.3 version added #1063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f8d927
Changes for version support updates
kedarkhaire Jun 18, 2024
2841548
Replacing deprecated ModuleHandlerInterface
kedarkhaire Jun 19, 2024
2e27d37
Replacing deprecated class RenderElement with RenderElementBase
kedarkhaire Jun 19, 2024
f9a0f5f
Replace the deprecated constants of FileSystemInterface
kedarkhaire Jun 19, 2024
7fe5979
Mark the callback directly with a PHP attribute TrustedCallback
kedarkhaire Jun 19, 2024
bfcfa67
Removing deprecated changes
kedarkhaire Jun 24, 2024
042892c
Removed 10.3 check
kedarkhaire Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ jobs:
php-version:
- "8.1"
- "8.2"
- "8.3"
drupal-core:
# Should update the following as the minimum supported version from Drupal.org
- "10.1.x"
- "10.2.x"
instance-type:
- "Edge"
Expand Down Expand Up @@ -137,13 +137,13 @@ jobs:
sudo Xvfb -ac :99 -screen 0 1280x1024x24 > /dev/null 2>&1 & # optional

- name: "Run PHPUnit tests"
if: ${{ matrix.drupal-core != '10.1.x' || matrix.php-version != '8.1' }}
if: ${{ matrix.drupal-core != '10.2.x' || matrix.php-version != '8.2' }}
run: |
cd drupal
vendor/bin/phpunit -c core --verbose --color --group apigee_edge --testsuite unit,kernel,functional,functional-javascript modules/contrib/apigee_edge

- name: "Run PHPUnit tests with Code Coverage"
if: ${{ matrix.drupal-core == '10.1.x' && matrix.php-version == '8.1' }}
if: ${{ matrix.drupal-core == '10.2.x' && matrix.php-version == '8.2' }}
run: |
cd drupal
cp modules/contrib/apigee_edge/phpunit.core.xml.dist core/phpunit.xml
Expand All @@ -157,7 +157,7 @@ jobs:
path: drupal/sites/simpletest/browser_output/*

- name: Upload coverage to Codecov
if: ${{ matrix.drupal-core == '10.1.x' && matrix.php-version == '8.1' }}
if: ${{ matrix.drupal-core == '10.2.x' && matrix.php-version == '8.2' }}
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "drupal-module",
"description": "Apigee for Drupal.",
"require": {
"php": "~8.1.0 || ~8.2.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"ext-json": "*",
"apigee/apigee-client-php": "~3.0.5",
"drupal/core": "^10.1",
Expand Down
Loading