Traktor: Fixed Vulkan validation issues, one with gbuffer format and …

…one in terrain culling.
apistol78 · Jun 11, 2024 · 1f38651 · 1f38651
1 parent ad7ba26
commit 1f38651
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/code/Terrain/TerrainComponent.cpp b/code/Terrain/TerrainComponent.cpp
@@ -647,6 +647,7 @@ bool TerrainComponent::createPatches()
 	safeDestroy(m_indexBuffer);
 	safeDestroy(m_vertexBuffer);
 	safeDestroy(m_drawBuffer);
+	safeDestroy(m_culledDrawBuffer);
 	safeDestroy(m_dataBuffer);
 
 	const uint32_t heightfieldSize = m_heightfield->getSize();
@@ -844,15 +845,15 @@ bool TerrainComponent::createPatches()
 	const uint32_t alignedPatchCount = alignUp((uint32_t)m_patches.size(), 16);
 
 	m_drawBuffer = m_renderSystem->createBuffer(
-		render::BuIndirect,
+		render::BuStructured | render::BuIndirect,
 		alignedPatchCount * sizeof(render::IndexedIndirectDraw),
 		true
 	);
 	if (!m_drawBuffer)
 		return false;
 
 	m_culledDrawBuffer = m_renderSystem->createBuffer(
-		render::BuIndirect,
+		render::BuStructured | render::BuIndirect,
 		alignedPatchCount * sizeof(render::IndexedIndirectDraw),
 		false
 	);

diff --git a/code/World/Shared/Passes/GBufferPass.cpp b/code/World/Shared/Passes/GBufferPass.cpp
@@ -56,7 +56,7 @@ render::handle_t GBufferPass::setup(
 	rgtd.targets[0].colorFormat = render::TfR16G16B16A16F;	// (GBufferA) Depth (R), Normal (GBA)
 	rgtd.targets[1].colorFormat = render::TfR8G8B8A8;		// (GBufferB) Albedo (RGB)
 	rgtd.targets[2].colorFormat = render::TfR8G8B8A8;		// (GBufferC) Roughness (R), Metalness (G), Specular (B), Decal Response (A)
-	rgtd.targets[3].colorFormat = render::TfR10G10B10A2;	// (GBufferD) Irradiance (RGB)
+	rgtd.targets[3].colorFormat = render::TfR8G8B8A8;	// (GBufferD) Irradiance (RGB)
 
 	auto gbufferTargetSetId = renderGraph.addTransientTargetSet(L"GBuffer", rgtd, outputTargetSetId, outputTargetSetId);