Traktor: Fixed some minor static analysis issues.

apistol78 · Nov 2, 2023 · c4ea910 · c4ea910
1 parent 5d40259
commit c4ea910
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/code/Core/InplaceRef.h b/code/Core/InplaceRef.h
@@ -91,7 +91,7 @@ class InplaceRef
 		return *this;
 	}
 
-	const InplaceRef& operator = (const InplaceRef&& ref) const
+	const InplaceRef& operator = (const InplaceRef&& ref) const noexcept
 	{
 		T_SAFE_ADDREF(ref.m_ref);
 		T_SAFE_RELEASE(m_ref);

diff --git a/code/Shape/Editor/Bake/BakePipelineOperator.cpp b/code/Shape/Editor/Bake/BakePipelineOperator.cpp
@@ -585,7 +585,7 @@ bool BakePipelineOperator::build(
 				}
 
 				// Include in bake.
-				auto componentDatas = inoutEntityData->getComponents();
+				const auto& componentDatas = inoutEntityData->getComponents();
 				for (auto componentData : componentDatas)
 				{
 					if (m_entityReplicators.find(&type_of(componentData)) != m_entityReplicators.end())

diff --git a/code/Shape/Editor/Bake/TracerProcessor.cpp b/code/Shape/Editor/Bake/TracerProcessor.cpp
@@ -357,7 +357,7 @@ void TracerProcessor::setEnable(bool enable)
 
 void TracerProcessor::processorThread()
 {
-	int32_t pending;
+	int32_t pending = 0;
 	Timer timer;
 
 	while (!m_thread->stopped())
@@ -669,7 +669,7 @@ bool TracerProcessor::process(const TracerTask* task)
 			T_FATAL_ASSERT(sh->get().size() == 9);
 			for (int32_t i = 0; i < 9; ++i)
 			{
-				auto c = (*sh)[i];
+				const auto& c = (*sh)[i];
 				writer << c.x();
 				writer << c.y();
 				writer << c.z();

diff --git a/code/World/Shared/Passes/GBufferPass.cpp b/code/World/Shared/Passes/GBufferPass.cpp
@@ -114,7 +114,7 @@ render::handle_t GBufferPass::setup(
 
 			T_ASSERT(!renderContext->havePendingDraws());
 
-			for (auto r : gatheredView.renderables)
+			for (const auto& r : gatheredView.renderables)
 				r.renderer->build(wc, worldRenderView, gbufferPass, r.renderable);
 
 			for (auto entityRenderer : m_entityRenderers->get())