Merge pull request #178 from codefresh-io/fix-memory-leak

fix: fix memory leak if `timeout` is set
apocas · Jan 3, 2025 · dc8d82a · dc8d82a
2 parents 1712ff1 + 15a8059
commit dc8d82a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/lib/modem.js b/lib/modem.js
@@ -283,17 +283,15 @@ Modem.prototype.buildRequest = function (options, context, data, callback) {
   if (self.connectionTimeout) {
     connectionTimeoutTimer = setTimeout(function () {
       debug('Connection Timeout of %s ms exceeded', self.connectionTimeout);
-      req.abort();
+      req.destroy();
     }, self.connectionTimeout);
   }
 
   if (self.timeout) {
-    req.on('socket', function (socket) {
-      socket.setTimeout(self.timeout);
-      socket.on('timeout', function () {
-        debug('Timeout of %s ms exceeded', self.timeout);
-        req.abort();
-      });
+    req.setTimeout(self.timeout);
+    req.on('timeout', function () {
+      debug('Timeout of %s ms exceeded', self.timeout);
+      req.destroy();
     });
   }
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "docker-modem",
   "description": "Docker remote API network layer module.",
-  "version": "5.0.3",
+  "version": "5.0.4",
   "author": "Pedro Dias <[email protected]>",
   "maintainers": [
     "apocas <[email protected]>"