[Fixes #180] Allow for root-level arrays to be querystring-ed in Modem.prototype.buildQuerystring #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clovel
changed the title
Signed-off-by: Clovis Durand <[email protected]>
|
I tried running the GitHub Actions on my fork and there seems to be an issue with Node 18 & Node 22 because of sshfs. This seems unrelated to my changes. Node 14 passed. |
|
It seems that all GitHub Actions have passed over on this repo ! that's good news |
|
Hi @apocas, Now that this is merged, when can we expect a release tag to be published to NPM with this fix ? Is a release scheduled soon ? |
|
Published v5.0.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the behaviour of
Modem.prototype.buildQuerystringfor root-level arrays.It fixes these issues :
changesarray parameter for/create/imageisn't serialized correctly #180I have launched the tests on
docker-modemanddockerode(by setting my fork as the source for NPM) and they all pass. Versions are :Windows :
Let me know if anything more needs to be checked.