Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update examples, fix hooks example in readme #413

Merged
merged 4 commits into from
Jan 9, 2021

Conversation

wodCZ
Copy link
Collaborator

@wodCZ wodCZ commented Jan 3, 2021

Based on the issue #412 I've updated the react native example app.

I'm thinking of dropping simplifying the readme examples (maybe keeping just one with hooks?) in favour of the example app, as the readme one tends to get out of date.

@wtrocki
Copy link
Collaborator

wtrocki commented Jan 4, 2021

+100

@wodCZ wodCZ force-pushed the feature/react-native-example branch from b78ab03 to c9453d3 Compare January 8, 2021 20:52
@wodCZ wodCZ marked this pull request as ready for review January 8, 2021 20:53
@wodCZ
Copy link
Collaborator Author

wodCZ commented Jan 8, 2021

I've also updated the web example, it's mostly the same as the react-native example (the used wrapper and styles are different). While I was there, I updated it's dependencies too.

I've removed the class example and fixed the hooks example and added few links to examples directory where they felt relevant.

Also, the API used in previous examples was terribly unstable (usually took few minutes to boot, then it worked fine for some time), so I replaced it with the Space X api, that doesn't require any API key and is consistently fast.

Finally, I've removed the Reactive Variable example, since it was more confusing than useful. Took me a while to realise it's there to demonstrate it doesn't persist (few others were confused too in the original issue). I took a while to check the implementation, and I don't believe it would be possible to add support for RV to this library anytime soon.

I'm done with this PR, let me know if there's something you'd like to change ;)

image

@wodCZ wodCZ changed the title update react native example update examples, fix hooks example in readme Jan 8, 2021
@wtrocki
Copy link
Collaborator

wtrocki commented Jan 9, 2021

Amazing work!

Copy link
Collaborator

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. All good

@wtrocki wtrocki merged commit 6262373 into apollographql:master Jan 9, 2021
@wodCZ wodCZ deleted the feature/react-native-example branch January 11, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants