New testing helpers using using, replace old console mocking functi…

…ons. (#11177)

.eslintrc

@@ -1,6 +1,6 @@
 {
   "parser": "@typescript-eslint/parser",
-  "plugins": ["@typescript-eslint", "import"],
+  "plugins": ["@typescript-eslint", "import", "local-rules"],
   "env": {
     "browser": true,
     "node": true,
@@ -52,15 +52,25 @@
             "ignorePackages": true,
             "checkTypeImports": true
           }
-        ]
+        ],
+        "local-rules/require-using-disposable": "error"
       }
     },
     {
-      "files": ["**/__tests__/**/*.[jt]sx", "**/?(*.)+(test).[jt]sx"],
+      "files": [
+        "**/__tests__/**/*.[jt]s",
+        "**/__tests__/**/*.[jt]sx",
+        "**/?(*.)+(test).[jt]s",
+        "**/?(*.)+(test).[jt]sx"
+      ],
       "extends": ["plugin:testing-library/react"],
+      "parserOptions": {
+        "project": "./tsconfig.tests.json"
+      },
       "rules": {
         "testing-library/prefer-user-event": "error",
-        "testing-library/no-wait-for-multiple-assertions": "off"
+        "testing-library/no-wait-for-multiple-assertions": "off",
+        "local-rules/require-using-disposable": "error"
       }
     }
   ],

config/version.js

@@ -30,11 +30,9 @@ switch (process.argv[2]) {
   }
 
   case "verify": {
-    const { ApolloClient, InMemoryCache } = require(path.join(
-      distRoot,
-      "core",
-      "core.cjs"
-    ));
+    const { ApolloClient, InMemoryCache } = require(
+      path.join(distRoot, "core", "core.cjs")
+    );
 
     // Though this may seem like overkill, verifying that ApolloClient is
     // constructible in Node.js is actually pretty useful, too!

eslint-local-rules/fixtures/tsconfig.json

@@ -0,0 +1,7 @@
+{
+  "compilerOptions": {
+    "strict": true,
+    "target": "esnext"
+  },
+  "include": ["file.ts", "react.tsx"]
+}

eslint-local-rules/index.js

@@ -0,0 +1,14 @@
+require("ts-node").register({
+  transpileOnly: true,
+  compilerOptions: {
+    // we need this to be nodenext in the tsconfig, because
+    // @typescript-eslint/utils only seems to export ESM
+    // in TypeScript's eyes, but it totally works
+    module: "commonjs",
+    moduleResolution: "node",
+  },
+});
+
+module.exports = {
+  "require-using-disposable": require("./require-using-disposable").rule,
+};

eslint-local-rules/package.json

@@ -0,0 +1,5 @@
+{
+  "scripts": {
+    "test": "node -r ts-node/register/transpile-only --no-warnings --test --watch *.test.ts"
+  }
+}

eslint-local-rules/require-using-disposable.test.ts

@@ -0,0 +1,31 @@
+import { rule } from "./require-using-disposable";
+import { ruleTester } from "./testSetup";
+
+ruleTester.run("require-using-disposable", rule, {
+  valid: [
+    `
+    function foo(): Disposable {}
+    using bar = foo()
+    `,
+    `
+    function foo(): AsyncDisposable {}
+    await using bar = foo()
+    `,
+  ],
+  invalid: [
+    {
+      code: `
+      function foo(): Disposable {}
+      const bar = foo()
+      `,
+      errors: [{ messageId: "missingUsing" }],
+    },
+    {
+      code: `
+      function foo(): AsyncDisposable {}
+      const bar = foo()
+      `,
+      errors: [{ messageId: "missingAwaitUsing" }],
+    },
+  ],
+});

eslint-local-rules/require-using-disposable.ts

@@ -0,0 +1,63 @@
+import { ESLintUtils } from "@typescript-eslint/utils";
+import ts from "typescript";
+import * as utils from "ts-api-utils";
+
+export const rule = ESLintUtils.RuleCreator.withoutDocs({
+  create(context) {
+    return {
+      VariableDeclaration(node) {
+        for (const declarator of node.declarations) {
+          if (!declarator.init) continue;
+          const services = ESLintUtils.getParserServices(context);
+          const type = services.getTypeAtLocation(declarator.init);
+          for (const typePart of parts(type)) {
+            if (!utils.isObjectType(typePart) || !typePart.symbol) {
+              continue;
+            }
+            if (
+              // bad check, but will do for now
+              // in the future, we should check for a `[Symbol.disposable]` property
+              // but I have no idea how to do that right now
+              typePart.symbol.escapedName === "Disposable" &&
+              node.kind != "using"
+            ) {
+              context.report({
+                messageId: "missingUsing",
+                node: declarator,
+              });
+            }
+            if (
+              // similarly bad check
+              typePart.symbol.escapedName === "AsyncDisposable" &&
+              node.kind != "await using"
+            ) {
+              context.report({
+                messageId: "missingAwaitUsing",
+                node: declarator,
+              });
+            }
+          }
+        }
+      },
+    };
+  },
+  meta: {
+    messages: {
+      missingUsing:
+        "Disposables should be allocated with `using <disposable>`.",
+      missingAwaitUsing:
+        "AsyncDisposables should be allocated with `await using <disposable>`.",
+    },
+    type: "suggestion",
+    schema: [],
+  },
+  defaultOptions: [],
+});
+
+function parts(type: ts.Type): ts.Type[] {
+  return type.isUnion()
+    ? utils.unionTypeParts(type).flatMap(parts)
+    : type.isIntersection()
+    ? utils.intersectionTypeParts(type).flatMap(parts)
+    : [type];
+}

eslint-local-rules/testSetup.ts

@@ -0,0 +1,15 @@
+import { RuleTester } from "@typescript-eslint/rule-tester";
+import nodeTest from "node:test";
+
+RuleTester.it = nodeTest.it;
+RuleTester.itOnly = nodeTest.only;
+RuleTester.describe = nodeTest.describe;
+RuleTester.afterAll = nodeTest.after;
+
+export const ruleTester = new RuleTester({
+  parser: "@typescript-eslint/parser",
+  parserOptions: {
+    project: "./tsconfig.json",
+    tsconfigRootDir: __dirname + "/fixtures",
+  },
+});

eslint-local-rules/tsconfig.json

@@ -0,0 +1,7 @@
+{
+  "extends": "@tsconfig/node20/tsconfig.json",
+  "compilerOptions": {
+    "allowJs": true,
+    "noEmit": true
+  }
+}