Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relayStylePagination concatenates edges when a query using after is repeated #9802

Open
srmagura opened this issue Jun 9, 2022 · 0 comments · May be fixed by #9803
Open

relayStylePagination concatenates edges when a query using after is repeated #9802

srmagura opened this issue Jun 9, 2022 · 0 comments · May be fixed by #9803
Labels
🐞 bug

Comments

@srmagura
Copy link

srmagura commented Jun 9, 2022 •
edited
Loading

Intended outcome:
If you use relayStylePagination with a query that uses after, and the same query is performed twice with the same value of after, the incoming edges should replace the existing edges.

Actual outcome:
If you use relayStylePagination with a query that uses after, and the same query is performed twice with the same value of after, the incoming edges are concatenated to the existing edges. Now your paginated list shows the same page of data twice.

How to reproduce the issue:
Run the test in PR #9803.

Versions
Tested in the apollo-client repository as of 538b795.
@srmagura srmagura linked a pull request Jun 9, 2022 that will close this issue
Open
2 tasks
@jpvajda jpvajda added 🐞 bug 🏓 awaiting-contributor-response requires input from a contributor and removed 🏓 awaiting-contributor-response requires input from a contributor labels Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change behavior of relayStylePagination merge function srmagura/apollo-client
2 participants
@srmagura @jpvajda