Change behavior of relayStylePagination merge function
#9803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srmagura: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
CI seems to have failed on something unrelated to my changes... maybe a flaky test? Everything was passing locally. |
|
Converting to draft since, I think this bug also affects pagination with |
It now replaces existing edges when it receives an unknown cursor.
srmagura
force-pushed
the
fix-relay-style-pagination-after
branch
from
f159f66 to
edb5c38
Compare
|
OK, this is ready for review. I also updated the description of the PR. |
srmagura
changed the title
relayStylePagination bug when using afterrelayStylePagination merge function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9802. See the issue for the actual vs. expected behavior before this patch.
I have tested this change in my real application and it fixed the problem I was experiencing.
Edit: After thinking about this more, the issue is less clearcut than I thought. Still, I believe the new behavior of
mergeis more correct. I added a long comment aboverelayStylePaginationthat explains why this is a tricky issue and why I think replacing the existing edges is the more-correct behavior.Would this be considered a breaking change? In one sense, it is definitely a breaking change. In another sense, it makes the function behave more correctly, and any bug fix can be construed as a breaking change if people relied on the buggy behavior.
Checklist: