-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate useFragement
returnPartialData
option
#10764
Conversation
🦋 Changeset detectedLatest commit: d0b1fa5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
885a02e
to
98ec144
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks great! Spotted a couple typos. Thanks for creating this PR!
Co-authored-by: Jerel Miller <[email protected]>
This is an alternative to #10760 and would address #10650.
It would mark the
returnPartialData
option ofuseFragement
as@deprecated
in v3.7. Once that has moved in and is merged into 3.8, I will add another PR that removes the option.This also adds test for the current default value of
true
(which was documented asfalse
until now, by inheriting from other options interfaces) and the behaviour ofthrow
ing an error in case of incomplete data withreturnPartialData: false
- which was not intended, but would IMHO be too much of a change to be fixed within 3.7.Checklist: