-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move hook documentation (and others) into code, improve documentation components #11381
Conversation
|
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This reverts commit 57c8526.
only show parameters section if there are parameters only show results if result is not `void` or user-specified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of really great stuff in here! Sorry for all the noise. Hope my comments are useful!
@@ -13,7 +13,7 @@ | |||
npm run docmodel | |||
cd ../ | |||
rm -rf monodocs | |||
git clone https://github.com/apollographql/docs --branch main --single-branch monodocs | |||
git clone https://github.com/apollographql/docs --branch pr/apidoc-enums-since --single-branch monodocs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to update this at some point 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. We will need to merge this branch, then merge the docs PR and then update main :)
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
@@ -13,7 +13,7 @@ | |||
npm run docmodel | |||
cd ../ | |||
rm -rf monodocs | |||
git clone https://github.com/apollographql/docs --branch main --single-branch monodocs | |||
git clone https://github.com/apollographql/docs --branch pr/apidoc-enums-since --single-branch monodocs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. We will need to merge this branch, then merge the docs PR and then update main :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chatted in person and am happy with the current results. 🚢 it!
PR scope & features:
FunctionDetails
ParameterTable
PropertySignatureTable
EnumDetails
PropertyDetails
@deprecated
@since
@returns
@alpha
,@beta
,@experimental
are technically possible, but are not implemented in any UI componentsLink changes
Hashes for links now change, so instead of
hooks#uselazyquery
hooks#params-1
(useQuery
parameters arehooks#params
,useMutation
parameters arehooks#params-2
)hooks#client
(actually points up touseQuery
, notuseLazyQuery
They now look like
hooks#uselazyquery
hooks#uselazyquery-parameters
hooks#uselazyquery-parameters-options-client
migrated hooks
hooks.mdx
useApolloClient
useQuery
useLazyQuery
useMutation
useSubscription
useReactiveVar
useFragment
(out of scope)useSuspenseQuery
(out of scope)useBackgroundQuery
(out of scope)useReadQuery
(out of scope)Inlined files into comments:
docs/shared/document-transform-options.mdx
docs/shared/mutation-options.mdx
docs/shared/mutation-result.mdx
docs/shared/query-options.mdx
docs/shared/query-result.mdx
docs/shared/subscription-options.mdx
docs/shared/subscription-result.mdx
docs/shared/useSuspenseQuery-options.mdx
Features added in Docs ( see sibling PR apollographql/docs#713 ):
@since
tag@returns
tagMDX
@docGroup
tag@alpha
,@beta
and@experimental
tags (not used over in AC yet)scrollMarginTop
forp
tags (since not all anchors/ids areh6
anymore now)<details>
tags if a hash navigates to one of their childrenDiffSite
For reviewing this PR, a side-by-side view might be useful - try this:
DiffSite
Impacted pages:
useQuery
touseReactiveVar
, theoptions
part ofuseSuspenseQuery
)useMutation
API options & result)useQuery
API options & result)useSubscription
options & results)