-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt at preventing feuds in combination with a read
function
#11430
base: release-3.9
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: b4100b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
/release:pr |
A new release has been made for this PR. You can install it with |
It seems to fix the example given by @marco2216 CodeSandBox, but at this point this will need more investigating if there are any negative side effects. |
} else if (count === 3) { | ||
expect(result).toEqual({ | ||
loading: true, | ||
networkStatus: NetworkStatus.loading, | ||
data: { | ||
info: {}, | ||
}, | ||
partial: true, | ||
}); | ||
} else if (count === 4) { | ||
expect(result).toEqual({ | ||
loading: false, | ||
networkStatus: NetworkStatus.ready, | ||
data: { | ||
info: {}, | ||
}, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably good that this isn't happening anymore - that doesn't seem like desirable behaviour?
Any idea when this PR will be merged? :) |
@phryneas are you still interested in moving this PR forward? |
This might address the feud showcased in #7028 - I'll have to give it a PR release and a spin.
Checklist: