fix: avoid redundant refetchQueries call for mutation with no-cache policy

[vladar]

This is a quick small fix for the bug outlined in #10238

In the nutshell, mutation.refetchQueries below is an empty array, not boolean or undefined. So this check errorneously evaluates to true even when the refetchQueries option is not set for the mutation.

The fix in this PR is a bit defensive - in case if it could be actually something other than array.

apollo-client/src/core/QueryManager.ts

Lines 400 to 406 in 31fc8df

	if (
	cacheWrites.length > 0 ||
	mutation.refetchQueries ||
	mutation.update ||
	mutation.onQueryUpdated ||
	mutation.removeOptimistic
	) {

Fixes #10238

[netlify]

‼️ Deploy request for apollo-client-docs rejected.

Name	Link
🔨 Latest commit	35e9f36

[changeset-bot]

🦋 Changeset detected

Latest commit: 35e9f36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[phryneas]

Hi, this is a very good catch, thank you for that!

I've made some suggestions that would keep the change in bundle size down a bit - what do you think?

[vladar]

Hi, this is a very good catch, thank you for that!

I've made some suggestions that would keep the change in bundle size down a bit - what do you think?

Updated, thanks. But looks like it doesn't help with size check.

[phryneas]

Don't worry about the size check - I'll fix that up before merging :)

This looks good to me. We're currently in a code freeze, so this will probably be released in a 3.9.1 after we've released our 3.9 minor.

[jerelmiller]

🎉 Now with 3.9 out, we'll get this into 3.9.1 🙂