Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only open a prerelease version packages PR when still in prerelease mode #11539

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

alessbell
Copy link
Contributor

Avoids opening a PR after we've exited prerelease mode and before the release branch has been merged. Example of erroneous PR: #11538

@alessbell alessbell requested a review from a team as a code owner January 30, 2024 19:21
Copy link

changeset-bot bot commented Jan 30, 2024

⚠️ No Changeset found

Latest commit: 1aa3bd1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -59,6 +59,7 @@ jobs:
run: npx changeset pre enter alpha

- name: Create prerelease PR
if: steps.check_files.outputs.files_exists == 'true'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks for presence of .changeset/pre.json

Copy link
Contributor

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 37.04 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 43.5 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 41.99 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.53 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.22 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.22 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.2 KB (0%)
import { useQuery } from "dist/react/index.js" 4.27 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.08 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 4.58 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.39 KB (0%)
import { useMutation } from "dist/react/index.js" 2.55 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.53 KB (0%)
import { useSubscription } from "dist/react/index.js" 2.23 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.19 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 4.61 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.05 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.13 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.55 KB (0%)
import { useReadQuery } from "dist/react/index.js" 2.99 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 2.93 KB (0%)
import { useFragment } from "dist/react/index.js" 2.17 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.11 KB (0%)

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@github-actions github-actions bot added the auto-cleanup 🤖 label Jan 30, 2024
@alessbell alessbell merged commit 40685cf into main Jan 30, 2024
30 checks passed
@alessbell alessbell deleted the skip-prerelease-pr-after-exiting-pre-mode branch January 30, 2024 20:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants