Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace Generics in PropertySignatureTable" #11549

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

jerelmiller
Copy link
Member

@jerelmiller jerelmiller commented Feb 1, 2024

Reverts #11527

Unfortunately there are a few too many cases where we aren't able to parse the nodes due to complex types, so I'm reverting this for now in an effort to ensure docs PRs can continue to be merged.

Here is the log for reference: https://app.netlify.com/sites/apollo-monodocs/deploys/65bae51fbe2f2506e3406166

@jerelmiller jerelmiller requested review from a team as code owners February 1, 2024 00:47
Copy link

changeset-bot bot commented Feb 1, 2024

⚠️ No Changeset found

Latest commit: da5a5a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 1, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.15 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 45.97 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 43.5 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 33.88 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.8 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.21 KB (0%)
import { useQuery } from "dist/react/index.js" 5.2 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.27 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.5 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.58 KB (0%)
import { useMutation } from "dist/react/index.js" 3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.73 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.38 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.28 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 3.94 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.75 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.4 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 4.97 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.63 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.04 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 2.98 KB (0%)
import { useFragment } from "dist/react/index.js" 2.18 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.13 KB (0%)

@jerelmiller jerelmiller merged commit f688036 into main Feb 1, 2024
28 of 33 checks passed
@jerelmiller jerelmiller deleted the revert-11527-pr/docs-generics branch February 1, 2024 00:51
phryneas added a commit that referenced this pull request Feb 1, 2024
phryneas added a commit that referenced this pull request Feb 1, 2024
* Revert "Revert "Replace Generics in PropertySignatureTable (#11527)" (#11549)"

This reverts commit f688036.

* remove log

* switch monodocs build to `main`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant