Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canary test adjustments #12233

Merged
merged 5 commits into from
Dec 18, 2024
Merged

canary test adjustments #12233

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c21368
run on multiple branches, log installed versions, adjust test command
phryneas Dec 18, 2024
23db3f0
add `|| true`
phryneas Dec 18, 2024
3868f31
different react version logging
phryneas Dec 18, 2024
110596c
allow inputs on dispatch
phryneas Dec 18, 2024
f5940b7
wording
phryneas Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions .github/workflows/scheduled-test-canary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# a GitHub Action that once a day runs all tests from `main` and `release-*` branches
# with the latest `canary` and `experimental` release of `react` and `react-dom`

name: Scheduled React Canary Test
on:
schedule:
- cron: "0 0 * * *"
Expand All @@ -14,12 +14,21 @@ jobs:
tag:
- canary
- experimental
branch:
- main
- release-3.13
- release-4.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I unfortunately don't see an easy way around hardcoding these.

steps:
- uses: actions/checkout@v4
with:
ref: ${{ matrix.branch }}
- uses: actions/setup-node@v4
with:
node-version: 22.x
- uses: bahmutov/npm-install@v1
- run: npm install react@${{ matrix.tag }} react-dom@${{ matrix.tag }}
- run: |
npm install react@${{ matrix.tag }} react-dom@${{ matrix.tag }}
# tests can be flaky, this runs only once a day and we want to minimize false negatives - retry up to three times
- run: "parallel --line-buffer -j 1 --retries 3 'npm run test:ci -- --selectProjects ' ::: 'ReactDOM 19'"
- run: |
node -e 'console.log("\n\nReact %s, React-DOM %s\n\n", require("react").version, require("react-dom").version)'
parallel --line-buffer -j 1 --retries 3 'npm test -- --logHeapUsage --selectProjects ' ::: 'ReactDOM 19'
Loading