add one more case for type without cachecontrol implementing interfac…

…e with cachecontrol
apollographql · Aug 7, 2024 · 711bf03 · 711bf03
1 parent b66f889
commit 711bf03
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/.changeset/many-shirts-kneel.md b/.changeset/many-shirts-kneel.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/packages/server/src/__tests__/plugin/cacheControl/cacheControlDirective.test.ts b/packages/server/src/__tests__/plugin/cacheControl/cacheControlDirective.test.ts
@@ -280,16 +280,22 @@ describe('@cacheControl directives', () => {
   it('interaction between type implementing interface, both with specified `maxAge`', async () => {
     const schema = buildSchemaWithCacheControlSupport(`
       type Query {
-        droid(id: ID!): Droid
         named: Named
+        droid(id: ID!): Droid
+        alien(id: ID!): Alien
+      }
+
+      interface Named @cacheControl(maxAge: 60) {
+        name: String!
       }
 
       type Droid implements Named @cacheControl(maxAge: 30) {
         id: ID!
         name: String!
       }
 
-      interface Named @cacheControl(maxAge: 60) {
+      type Alien implements Named {
+        id: ID!
         name: String!
       }
     `);
@@ -327,6 +333,23 @@ describe('@cacheControl directives', () => {
     expect(hintsDroid).toStrictEqual(
       new Map([['droid', { maxAge: 30, scope: undefined }]]),
     );
+
+    const hintsAlien = await collectCacheControlHints(
+      schema,
+      `
+        query {
+          alien(id: 3001) {
+            id
+            name
+          }
+        }
+      `,
+      { defaultMaxAge: 10 },
+    );
+
+    expect(hintsAlien).toStrictEqual(
+      new Map([['alien', { maxAge: 10, scope: undefined }]]),
+    );
   });
 
   it('inheritMaxAge', async () => {