Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deferSpec=20220824 from the response headers #7915

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −11
Open

Remove deferSpec=20220824 from the response headers #7915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/integration-testsuite/src/apolloServerTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1187,9 +1187,7 @@ export function defineIntegrationTestSuiteApolloServerTests(
expect(response.status).toBe(200);
expect(
response.headers.get('content-type'),
).toMatchInlineSnapshot(
`"multipart/mixed; boundary="-"; deferSpec=20220824"`,
);
).toMatchInlineSnapshot(`"multipart/mixed; boundary="-"`);
expect(await response.text()).toMatchInlineSnapshot(`
"
---
Expand Down
8 changes: 4 additions & 4 deletions packages/integration-testsuite/src/httpServerTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2197,7 +2197,7 @@ export function defineIntegrationTestSuiteHttpServerTests(
});
expect(res.status).toEqual(200);
expect(res.header['content-type']).toMatchInlineSnapshot(
`"multipart/mixed; boundary="-"; deferSpec=20220824"`,
`"multipart/mixed; boundary="-""`,
);
expect(res.text).toMatchInlineSnapshot(`
"
Expand Down Expand Up @@ -2267,7 +2267,7 @@ export function defineIntegrationTestSuiteHttpServerTests(
const res = await resPromise;
expect(res.status).toEqual(200);
expect(res.header['content-type']).toMatchInlineSnapshot(
`"multipart/mixed; boundary="-"; deferSpec=20220824"`,
`"multipart/mixed; boundary="-""`,
);
expect(res.text).toMatchInlineSnapshot(`
"
Expand Down Expand Up @@ -2354,7 +2354,7 @@ export function defineIntegrationTestSuiteHttpServerTests(
});
expect(res.status).toEqual(200);
expect(res.header['content-type']).toMatchInlineSnapshot(
`"multipart/mixed; boundary="-"; deferSpec=20220824"`,
`"multipart/mixed; boundary="-"`,
);
expect(res.text).toEqual(`\r
---\r
Expand Down Expand Up @@ -2404,7 +2404,7 @@ content-type: application/json; charset=utf-8\r
const res = await resPromise;
expect(res.status).toEqual(200);
expect(res.header['content-type']).toMatchInlineSnapshot(
`"multipart/mixed; boundary="-"; deferSpec=20220824"`,
`"multipart/mixed; boundary="-"`,
);
expect(res.text).toMatchInlineSnapshot(`
"
Expand Down
2 changes: 1 addition & 1 deletion packages/server/src/__tests__/express4/expressSpecific.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ it('incremental delivery works with compression', async () => {
// Confirm that the response has actually been gzipped.
expect(res.header['content-encoding']).toMatchInlineSnapshot(`"gzip"`);
expect(res.header['content-type']).toMatchInlineSnapshot(
`"multipart/mixed; boundary="-"; deferSpec=20220824"`,
`"multipart/mixed; boundary="-""`,
);
expect(res.text).toMatchInlineSnapshot(`
"
Expand Down
2 changes: 1 addition & 1 deletion packages/server/src/runHttpQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ export async function runHttpQuery<TContext extends BaseContext>({

graphQLResponse.http.headers.set(
'content-type',
'multipart/mixed; boundary="-"; deferSpec=20220824',
'multipart/mixed; boundary="-"',
);
return {
...graphQLResponse.http,
Expand Down
2 changes: 1 addition & 1 deletion smoke-test/smoke-test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ async function smokeTest() {

assert.strictEqual(
response.headers.get('content-type'),
'multipart/mixed; boundary="-"; deferSpec=20220824',
'multipart/mixed; boundary="-"',
);

const body = await response.text();
Expand Down
2 changes: 1 addition & 1 deletion smoke-test/smoke-test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ if (process.env.INCREMENTAL_DELIVERY_TESTS_ENABLED) {

assert.strictEqual(
response.headers.get('content-type'),
'multipart/mixed; boundary="-"; deferSpec=20220824',
'multipart/mixed; boundary="-"',
);

const body = await response.text();
Expand Down