-
Notifications
You must be signed in to change notification settings - Fork 2
Add a new npm package for shared helpers #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ons for Sandbox that aren't necessary in Explorer
…EmbedRelay & setupEmbedRelay & EmbeddedExplorer / EmbeddedSandbox
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0d7b48d:
|
|
It might be nice to use some of these helpers in studio as well, so we only have 1 implementation of the defer stuff? Or I guess we could just use |
|
@Jephuff I like that idea! I think we could reuse |
|
This needs to wait on release of #235 |
What? This PR adds a new npm package
@apollo/embed-helpersthat contains shared code between@apollo/sandboxand@apollo/explorer.Why? When we need to support new protocols, like @defer, multi part subscriptions, file upload, in our clients, we need to implement everything twice, in
@apollo/sandboxand@apollo/explorer.This is step one in migrating
@apollo/sandboxand@apollo/explorerto share this code.@apollo/sandboxand@apollo/explorer, remove redundant code!