Skip to content

Conversation

dotdat
Copy link
Contributor

@dotdat dotdat commented Oct 10, 2024

Makes FederationVersion::LatestFedTwo the default. This is to make sure we are looking forward to the future versions of composition as best as possible.

@dotdat dotdat requested review from a team as code owners October 10, 2024 17:56
@dylan-apollo
Copy link
Member

I think this would end up being a breaking change for customers, where if they don't have a specific federation version set in their supergraph.yaml, we're suddenly going to start upgrading them to fed 2 mode, right?

@dariuszkuc
Copy link
Member

Wondering whether latest is the right default, i.e. we definitely want to update the default to 2.x but I'd argue that we probably would want to target something like latest-1 (or some fixed fed version) for stability purposes.

Since we were defaulting to fed 1, customers wouldn't be using any fed 2 features so technically we could point to just to fed 2.0.

@abernix abernix requested review from a team and removed request for a team September 25, 2025 11:12
@abernix
Copy link
Member

abernix commented Sep 25, 2025

Without much consideration, I'm just going to close this. I think it's abandoned. :) Feel free to reopen.

@abernix abernix closed this Sep 25, 2025
@dariuszkuc dariuszkuc deleted the dotdat/federation-v2-default branch September 25, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants