You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working with elements with many referencers, addReferencer() became very hot.
If you have eg. 100 referencers, each one is added one by one, and each new addition iterates the entire existing referencers list. This could cause quadratic performance.
This changes the _referencers values to be JS Sets. This maintains the same order for algorithms that rely on order.
When working with elements with many referencers, `addReferencer()` became very hot.
If you have eg. 100 referencers, each one is added one by one, and each
new addition iterates the entire existing referencers list. This could
cause quadratic performance.
This changes the `_referencers` values to be JS `Set`s. This maintains
the same order for algorithms that rely on order.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
It actually might be good to convert unionsWhereMember and allImplementations, too. I didn't do it because it's more work. But allImplementations in particular is used for the runtimeTypesIntersect check, which is currently O(n^2), and could be O(n) if allImplementations used a Set. But maybe do that when we have an example query where it is very hot?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working with elements with many referencers,
addReferencer()became very hot.If you have eg. 100 referencers, each one is added one by one, and each new addition iterates the entire existing referencers list. This could cause quadratic performance.
This changes the
_referencersvalues to be JSSets. This maintains the same order for algorithms that rely on order.