Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Make SchemaUpgrader faster #3057

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

clenfest
Copy link
Contributor

@clenfest clenfest commented Jun 28, 2024

The idea is to make SchemaUpgrader faster by precomputing each type into a map that can be passed around once rather. Ideally we would be able to entirely get rid of otherSubgraphs as a parameter to SchemaUpgrader before this PR is ready.

Note that although this works with tests, I think there may be an issue with interfaces that isn't covered by tests, so do not merge unless someone has a chance to look at this with a critical eye. (I think the issue is that the map is built by iterating over objectTypes but later code iterates over types() which may include interfaces.

Copy link

changeset-bot bot commented Jun 28, 2024

⚠️ No Changeset found

Latest commit: cd2108f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jun 28, 2024

👷 Deploy Preview for apollo-federation-docs processing.

Name Link
🔨 Latest commit cb89af1
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/667f3386bd48fb00086f2d28

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for apollo-federation-docs canceled.

Name Link
🔨 Latest commit cd2108f
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/667f38e3eaa4510008bebed5

Copy link

codesandbox-ci bot commented Jun 28, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant