Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to make SchemaUpgrader faster by precomputing each type into a map that can be passed around once rather. Ideally we would be able to entirely get rid of
otherSubgraphs
as a parameter to SchemaUpgrader before this PR is ready.Note that although this works with tests, I think there may be an issue with interfaces that isn't covered by tests, so do not merge unless someone has a chance to look at this with a critical eye. (I think the issue is that the map is built by iterating over
objectTypes
but later code iterates overtypes()
which may include interfaces.