Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSONSelection] Add ->mapValues method to future:: namespace #6189

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Oct 23, 2024

PR #6185 removed support for the following syntax for preserving dynamic keys of dictionary objects while mapping their values:

booksByISBN: books { * { title author }}

As suggested in the description of PR #6185, this pattern can be replaced with a ->mapValues method call:

booksByISBN: books->mapValues(@ { title author })

This PR tentatively implements that ->mapValues method, filing it away in the future:: namespace to indicate it hasn't been shipped yet.

@benjamn benjamn self-assigned this Oct 23, 2024
@benjamn benjamn requested review from nicholascioli and a team as code owners October 23, 2024 18:01
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Oct 23, 2024

✅ Docs Preview Ready

No new or changed pages found.

@router-perf
Copy link

router-perf bot commented Oct 23, 2024

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

PR #6185 removed support for the following syntax for preserving dynamic
keys of dictionary objects while mapping their values:
```graphql
booksByISBN: books { * { title author }}
```

As suggested in the description of PR #6185, this pattern can be
replaced with a `->mapValues` method call:
```graphql
booksByISBN: books->mapValues(@ { title author })
```

This PR tentatively implements that `->mapValues` method, filing it away
in the `future::` namespace to indicate it hasn't been shipped yet.
@benjamn benjamn force-pushed the benjamn/JSONSelection-mapValues-method branch from a278496 to a26e478 Compare October 23, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants