Skip to content

Conversation

abernix
Copy link
Member

@abernix abernix commented Sep 5, 2025

Add explanation that router timeout should be >= subgraph timeouts.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Add explanation that router timeout should be >= subgraph timeouts.
@abernix abernix requested a review from a team as a code owner September 5, 2025 06:37
@apollo-librarian
Copy link

apollo-librarian bot commented Sep 5, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 3 changed, 0 removed
* graphos/routing/(latest)/observability/client-id-enforcement.mdx
* graphos/routing/(latest)/performance/traffic-shaping.mdx
* graphos/routing/(latest)/errors.mdx

Build ID: 8526b2a0cf1d61e7dbc6b13b
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/8526b2a0cf1d61e7dbc6b13b

This comment has been minimized.

traffic_shaping:
router:
timeout: 60s # Router: 60 seconds
all:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we say "Default for all subgraphs except the ones below" in the comment? The field name "all" is the one that confused me in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants