chore(tests): backfilling tests for the @policy directive
#8230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 75eb3d32e0b1f67dfad4cac8 |
|
@aaronArinder, please consider creating a changeset entry in |
lrlna
reviewed
Sep 9, 2025
Comment on lines
+45
to
+47
| private: Private @join__field(graph: SUBGRAPH_A) @policy(policies: [["admin"]]) | ||
| public: Public @join__field(graph: SUBGRAPH_A) | ||
| opensecret: OpenSecret @join__field(graph: SUBGRAPH_A) |
There was a problem hiding this comment.
we want another test that has a field defined like this. this the one that we are unsure about (although all the other ones are excellent to test as well 🙏 ):
Suggested change
| private: Private @join__field(graph: SUBGRAPH_A) @policy(policies: [["admin"]]) | |
| public: Public @join__field(graph: SUBGRAPH_A) | |
| opensecret: OpenSecret @join__field(graph: SUBGRAPH_A) | |
| private: Private @join__field(graph: SUBGRAPH_A) @policy(policies: [["admin"]]) | |
| public: Public @join__field(graph: SUBGRAPH_A) | |
| opensecret: OpenSecret @join__field(graph: SUBGRAPH_A) | |
| secure: Secure @join__field(graph: SUBGRAPH_A) |
There was a problem hiding this comment.
ptal; I think it's good now?
aaronArinder
commented
Sep 9, 2025
| private: Private @join__field(graph: SUBGRAPH_A) @policy(policies: [["admin"]]) | ||
| public: Public @join__field(graph: SUBGRAPH_A) | ||
| opensecret: OpenSecret @join__field(graph: SUBGRAPH_A) | ||
| secure: Secure @join__field(graph: SUBGRAPH_A) |
There was a problem hiding this comment.
line where secure was added (@lrlna)
aaronArinder
force-pushed
the
aaron/policy-debugging
branch
from
a7dc0a6 to
8bc9880
Compare
aaronArinder
changed the title
@policy and interfaces@policy directive
aaronArinder
force-pushed
the
aaron/policy-debugging
branch
5 times, most recently
from
18c1e35 to
3c061db
Compare
aaronArinder
force-pushed
the
aaron/policy-debugging
branch
from
3c061db to
20b7a52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩