add render and railway deployment pages #8242
Conversation
This comment has been minimized.
This comment has been minimized.
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 5 changed, 0 removedBuild ID: bf2ce87b5df5ed748e36d5cb URL: https://www.apollographql.com/docs/deploy-preview/bf2ce87b5df5ed748e36d5cb |
the-gigi-apollo
force-pushed
the
gigi/dxm-227-add-railway-and-render-deployment-guides
branch
from
61f3476 to
b12ea67
Compare
the-gigi-apollo
force-pushed
the
gigi/dxm-227-add-railway-and-render-deployment-guides
branch
from
b12ea67 to
ba1008d
Compare
| @@ -0,0 +1,5 @@ | |||
| ### add render and railway deployment pages ([PR #8242](https://github.com/apollographql/router/pull/8242)) | |||
|
|
|||
| [dxm-227](https://apollographql.atlassian.net/browse/DXM-227) | |||
There was a problem hiding this comment.
I don't think we want to add any Apollo-only ticket links to public changesets. Is this something we can still remove?
I believe we also don't typically add docs-only changes to a changeset... @abernix would you be able to confirm here? 🙏🏽
There was a problem hiding this comment.
@mabuyo Yes, this entire repository is public and so is this changelog — it's delivered with the release. We should remove this specific linkage and also make this changeset highlight the really great content that the rest of this PR adds!
We describe how this changeset should be here, but generally, our rules from style-guide.md / Librarian apply beyond that.
| - label: "Managed Hosting" | ||
| children: | ||
| - label: "Railway" | ||
| href: "./self-hosted/managed-hosting/railway" | ||
| - label: "Render" | ||
| href: "./self-hosted/managed-hosting/render" |
There was a problem hiding this comment.
Clicking on these from the sidebar is broken right now because we have to add them to the docs-rewrite repo in the _ref.yaml file. Came across this a few days ago pairing with other engineers.
cc @BlenderDude is this intentional? Why does the router _ref.yaml have to manually add each page but the MCP server _ref.yaml pattern matches every single MDX file?
There was a problem hiding this comment.
That seems like a problem as it requires PRs in two separate repos to me merged at the same time.
There was a problem hiding this comment.
At least at the time of creation, the old docs and the new docs required a different structure. If all pages within the routing folder (and all future pages!) are part of the docs at that location, we can update the ref file to use the glob grab-everything syntax.
There was a problem hiding this comment.
@the-gigi-apollo Let's work with this structure for now, I don't want to accidentally break anything. Can you open up a new PR to update the _ref.yaml file, merge that first, then come back to this one?
There was a problem hiding this comment.
Hey @mabuyo ,
I know that the docs-rewrite repo pulls content from other repos, but I'm not sure how to organize it. Can you provide more specific instructions what exactly should go in the _ref.yaml file?
I see that it currently pulls some subset of files from the router repo, but not sure how to update it.
There was a problem hiding this comment.
@the-gigi-apollo Please pull this branch from docs-rewrite and run locally! https://github.com/apollographql/docs-rewrite/pull/765
the-gigi-apollo
force-pushed
the
gigi/dxm-227-add-railway-and-render-deployment-guides
branch
2 times, most recently
from
7cca552 to
f93cb6b
Compare
the-gigi-apollo
force-pushed
the
gigi/dxm-227-add-railway-and-render-deployment-guides
branch
from
0a512ad to
8f2702a
Compare
dxm-227