Add header size and header list items limit middleware to expand request limits functionality #8284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the middleware functionality added in PR #8269 by implementing two new header-based request limits to enhance security against header-based attacks.
New Features
Header Size Limit (
http_max_header_size
)Limits the maximum size of individual HTTP headers (header name + header value combined). When a header exceeds this limit, the router responds with
431 Request Header Fields Too Large
.Header List Items Limit (
http_max_header_list_items
)Limits the maximum number of comma-separated items in HTTP header values. For example, a header like
Accept: text/html, application/json, */*
contains 3 items. This is useful for preventing abuse of headers that accept multiple values.Both limits default to unlimited (None) to maintain backward compatibility.
Implementation Details
header_limits.rs
withHeaderLimitLayer
andHeaderLimitService
RequestBodyLimitLayer
Testing
Documentation
Updated both configuration reference and security documentation with:
The implementation follows Apollo Router's established patterns and provides robust protection against header-based attacks while maintaining full backward compatibility.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com
/usr/lib/apt/methods/https
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
This pull request was created as a result of the following prompt from Copilot chat.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.