Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor rover dev for use with rover lsp #2170

Draft
wants to merge 60 commits into
base: language-server
Choose a base branch
from
Draft

Refactor rover dev for use with rover lsp #2170

wants to merge 60 commits into from

Commits on Sep 24, 2024

  1. add run composition tests (#2171) 

    Add unit tests for the `RunComposition` handler.
    @loshz
    loshz authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7d1628e View commit details
    Browse the repository at this point in the history

  2. add subgraph watcher handle tests (#2172) 

    Add tests for `SubgraphWatcher` handle events.
    @loshz
    loshz authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    64b0272 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Fix integration tests against the [supergraph-demo (#2175) 

    Fixes tests against the [supergraph demo
repo](https://github.com/apollographql/supergraph-demo). In the previous
iteration, the federation version resolver defaulted to the
`FederationVersion::LatestFedTwo` when it should have been
`FederationVersion::LatestFedOne`
    @dotdat
    dotdat authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dfc0d25 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. add tests for subgraph watchers parsing (#2177)

    @loshz
    loshz authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d911423 View commit details
    Browse the repository at this point in the history

  2. PoC of LSP in Rover

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    baf6827 View commit details
    Browse the repository at this point in the history

  3. update als

    @trevor-scheer @dylan-apollo
    trevor-scheer authored and dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    34b9d37 View commit details
    Browse the repository at this point in the history

  4. release: v0.27.0-alpha.0

    @trevor-scheer @dylan-apollo
    trevor-scheer authored and dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    ac3933c View commit details
    Browse the repository at this point in the history

  5. only build lsp mod with composition-js enabled

    @trevor-scheer @dylan-apollo
    trevor-scheer authored and dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5e79607 View commit details
    Browse the repository at this point in the history

  6. security + openssl fixes

    @trevor-scheer @dylan-apollo
    trevor-scheer authored and dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e7d219e View commit details
    Browse the repository at this point in the history

  7. Fix federation version from supergraph.yaml

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    558743f View commit details
    Browse the repository at this point in the history

  8. Remove multi-terminal session support

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    853ece1 View commit details
    Browse the repository at this point in the history

  9. Remove ipc & more multi-terminal leftovers

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    84c08bb View commit details
    Browse the repository at this point in the history

  10. Clean up more ipc residue

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    bf20d84 View commit details
    Browse the repository at this point in the history

  11. More renaming, remove shutdown event / ctrl-c handling since the stan… 

    …dard handling now works (no ipc)
    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a2a9859 View commit details
    Browse the repository at this point in the history

  12. Remove more leader/follower terminology, ditch now-useless leader mes… 

    …sages, stop double-printing
    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6409205 View commit details
    Browse the repository at this point in the history

  13. Refactor supergraph resolution to make it more type-safe. 

    Compose a single time at startup instead of adding/removing subgraphs from subgraph watchers.
    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9ff1a56 View commit details
    Browse the repository at this point in the history

  14. Start moving some fields into Composer

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    37188a8 View commit details
    Browse the repository at this point in the history

  15. Extract the composition logic from do_compose into Composer

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1267370 View commit details
    Browse the repository at this point in the history

  16. Simplify subgraph messages, use Tokio channels, finish getting rid of… 

    … `dev::protocol`
    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5614e22 View commit details
    Browse the repository at this point in the history

  17. Don't exit early if first composition fails

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    ef18924 View commit details
    Browse the repository at this point in the history

  18. Move all subgraph watching logic into new Watcher struct

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6fc355e View commit details
    Browse the repository at this point in the history

  19. Convert LSP to use new Watcher struct

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9f03068 View commit details
    Browse the repository at this point in the history

  20. Fix test compilation

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7ab0c9e View commit details
    Browse the repository at this point in the history

  21. Set root URI for LSP

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    0835025 View commit details
    Browse the repository at this point in the history

  22. Reduce file watcher debounce to speed up LSP feedback

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    52d1f2d View commit details
    Browse the repository at this point in the history

  23. Recompose when supergraph.yaml changes (doesn't _use_ the changes y… 

    …et, though)
    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a9802d9 View commit details
    Browse the repository at this point in the history

  24. Unbound the notification sender, so that lots of subgraphs don't bloc… 

    …k things up
    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    ce8d7ac View commit details
    Browse the repository at this point in the history

  25. Compose with a new version, when updated in supergraph.yaml

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6dd2b30 View commit details
    Browse the repository at this point in the history

  26. Use clap option for composition override instead of manual check

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    42f3ebe View commit details
    Browse the repository at this point in the history

  27. Fix some tests

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6962831 View commit details
    Browse the repository at this point in the history

  28. Get rid of pluralization specialization for composition errors, since… 

    … carrying around num_subgraphs was burdensome
    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    ea3c387 View commit details
    Browse the repository at this point in the history

  29. Removed federation version from _sometimes_ being included in _succes… 

    …s_ outputs only.
    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3d67be8 View commit details
    Browse the repository at this point in the history

  30. Use a helper function to update subgraphs in Composer

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    95bcd05 View commit details
    Browse the repository at this point in the history

  31. Break watcher event handling into its own function

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    38b4361 View commit details
    Browse the repository at this point in the history

  32. Move subgraph resolution into its own function for reuse later

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7409c9d View commit details
    Browse the repository at this point in the history

  33. Simplify resolve_subgraph error handling

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    b08e9b0 View commit details
    Browse the repository at this point in the history

  34. Move routing_url check into resolve_subgraph

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2186485 View commit details
    Browse the repository at this point in the history

  35. Finish resolve_subgraph refactor

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e1b6ced View commit details
    Browse the repository at this point in the history

  36. Add/remove subgraphs from composition when supergraph.yaml changes.… 

    … Doesn't spawn new watchers yet.
    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a5fee2f View commit details
    Browse the repository at this point in the history

  37. Update watchers (and LSP) when adding/removing subgraphs

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    cf28427 View commit details
    Browse the repository at this point in the history

  38. Use published version of apollo-language-server

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    ca8c960 View commit details
    Browse the repository at this point in the history

  39. Turn off federation module when composition-js is disabled

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    0bb2414 View commit details
    Browse the repository at this point in the history

  40. Report more errors up through events, reduce verbosity of rover dev… 

    … when recomposing.
    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    acc4c6b View commit details
    Browse the repository at this point in the history

  41. Add a TODO about not failing on startup in LSP

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    b6c62bb View commit details
    Browse the repository at this point in the history

  42. Hide rover lsp from rover --help

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    181e5fa View commit details
    Browse the repository at this point in the history

  43. release: v0.27.0-alpha.1

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2fe4da6 View commit details
    Browse the repository at this point in the history

  44. fix(openssl): downgrade openssl-src (#2174) 

    ```
 aaronarinder@Aarons-MBP  ~/apollo/rover   dylan/language-server+dev  cargo update openssl-src -
-precise 300.3.1+3.3.1
    Updating crates.io index
 Downgrading openssl-src v300.3.2+3.3.2 -> v300.3.1+3.3.1
```
    @aaronArinder @dylan-apollo
    aaronArinder authored and dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7a30b10 View commit details
    Browse the repository at this point in the history

  45. Default fed version to 1 (#2175)

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    483ce42 View commit details
    Browse the repository at this point in the history

  46. Remove noisy log when watchers stop & add extra debugging around comp… 

    …osition errors
    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a4cde15 View commit details
    Browse the repository at this point in the history

  47. Support relative paths to supergraph.yaml in lsp

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    bbc5e51 View commit details
    Browse the repository at this point in the history

  48. Fix remote + local federation version overrides

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    93a2580 View commit details
    Browse the repository at this point in the history

  49. Clear diagnostics on supergraph.yaml when composition completes.

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    ee5b0d0 View commit details
    Browse the repository at this point in the history

  50. Remove some TODOs that are TODONE

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    8a3e7ce View commit details
    Browse the repository at this point in the history

  51. Fix infinite CPU when rover dev restarts router

    @dylan-apollo
    dylan-apollo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6d89246 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Update to latest published apollo-language-server

    @dylan-apollo
    dylan-apollo committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a827162 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Remove some to-done todos

    @dylan-apollo
    dylan-apollo committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    38d8992 View commit details
    Browse the repository at this point in the history

  2. Revert macos kqueue to fsevent to solve watcher bug

    @dylan-apollo
    dylan-apollo committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7787673 View commit details
    Browse the repository at this point in the history

  3. Update apollo-language-server

    @dylan-apollo
    dylan-apollo committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d48b621 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. release: v0.27.0-preview.0

    @dylan-apollo
    dylan-apollo committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c657c4a View commit details
    Browse the repository at this point in the history

  2. Downgrade OpenSSL again

    @dylan-apollo
    dylan-apollo committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a79a647 View commit details
    Browse the repository at this point in the history