Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVO-241: Fix builder image to a valid-Konflux compliant one #418

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ncaak
Copy link
Contributor

@ncaak ncaak commented Feb 6, 2025

summary

Updated the base image used as builder for the operator Dockerfile.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 6, 2025

@ncaak: This pull request references DVO-241 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

summary

Updated the base image used as builder for the operator Dockerfile.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Feb 6, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 6, 2025
@ncaak ncaak force-pushed the DVO-241/replace-dockerfile-builder-image branch from 641f5d6 to 7fb3ae8 Compare February 7, 2025 14:41
@ncaak ncaak marked this pull request as ready for review February 7, 2025 15:24
@openshift-ci openshift-ci bot requested review from JoaoFula and tremes February 7, 2025 15:24
@ncaak
Copy link
Contributor Author

ncaak commented Feb 7, 2025

/test deployment-validation-operator-e2e-tests

Copy link

openshift-ci bot commented Feb 7, 2025

@ncaak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/deployment-validation-operator-e2e-tests 7fb3ae8 link true /test deployment-validation-operator-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (b82ff04) to head (7fb3ae8).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files          22       22           
  Lines        1083     1083           
=======================================
  Hits          500      500           
  Misses        553      553           
  Partials       30       30           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants