Skip to content

NO-JIRA: Add new team members#419

Merged
ncaak merged 1 commit intoapp-sre:masterfrom
ncaak:maintenance/update-owners-file
Feb 14, 2025
Merged

NO-JIRA: Add new team members#419
ncaak merged 1 commit intoapp-sre:masterfrom
ncaak:maintenance/update-owners-file

Conversation

@ncaak
Copy link
Copy Markdown
Contributor

@ncaak ncaak commented Feb 7, 2025

summary

Add new team-members' GitHub users to the OWNERS file to enable them to review and approve PRs from now on.

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@ncaak: This pull request explicitly references no jira issue.

Details

In response to this:

summary

Add new team-members' GitHub users to the OWNERS file to enable them to review and approve PRs from now on.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from JoaoFula and tremes February 7, 2025 09:41
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tremes
Copy link
Copy Markdown
Contributor

tremes commented Feb 7, 2025

/lgtm

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.16%. Comparing base (8c666cd) to head (e398edb).
⚠️ Report is 197 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #419   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files          22       22           
  Lines        1083     1083           
=======================================
  Hits          500      500           
  Misses        553      553           
  Partials       30       30           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ncaak
Copy link
Copy Markdown
Contributor Author

ncaak commented Feb 13, 2025

/verify-owners

1 similar comment
@ncaak
Copy link
Copy Markdown
Contributor Author

ncaak commented Feb 14, 2025

/verify-owners

@opokornyy
Copy link
Copy Markdown
Collaborator

/lgtm

@ncaak
Copy link
Copy Markdown
Contributor Author

ncaak commented Feb 14, 2025

/verify-owners

@ncaak ncaak merged commit b2e30d3 into app-sre:master Feb 14, 2025
@ncaak ncaak deleted the maintenance/update-owners-file branch November 13, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants