Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Add new team members #419

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

ncaak
Copy link
Contributor

@ncaak ncaak commented Feb 7, 2025

summary

Add new team-members' GitHub users to the OWNERS file to enable them to review and approve PRs from now on.

@openshift-ci-robot
Copy link
Collaborator

@ncaak: This pull request explicitly references no jira issue.

In response to this:

summary

Add new team-members' GitHub users to the OWNERS file to enable them to review and approve PRs from now on.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from JoaoFula and tremes February 7, 2025 09:41
Copy link

openshift-ci bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tremes
Copy link
Contributor

tremes commented Feb 7, 2025

/lgtm

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (8c666cd) to head (e398edb).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #419   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files          22       22           
  Lines        1083     1083           
=======================================
  Hits          500      500           
  Misses        553      553           
  Partials       30       30           

@ncaak
Copy link
Contributor Author

ncaak commented Feb 13, 2025

/verify-owners

1 similar comment
@ncaak
Copy link
Contributor Author

ncaak commented Feb 14, 2025

/verify-owners

@opokornyy
Copy link
Collaborator

/lgtm

@ncaak
Copy link
Contributor Author

ncaak commented Feb 14, 2025

/verify-owners

@ncaak ncaak merged commit b2e30d3 into app-sre:master Feb 14, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants