🐛 fix empty text and add debugging messages for pydantic model valida…

…tions (#18)

alert.attachments[].text can be None :(

Ticket: APPSRE-10541

glitchtip_jira_bridge/main.py

@@ -5,7 +5,11 @@
     APIRouter,
     Depends,
     FastAPI,
+    Request,
+    status,
 )
+from fastapi.exceptions import RequestValidationError
+from fastapi.responses import JSONResponse
 from prometheus_fastapi_instrumentator import Instrumentator
 
 from .api import router
@@ -45,6 +49,17 @@ def create_app() -> FastAPI:
     async def _startup() -> None:
         instrumentator.expose(fast_api_app, include_in_schema=False)
 
+    @fast_api_app.exception_handler(RequestValidationError)
+    async def validation_exception_handler(
+        request: Request, exc: RequestValidationError
+    ) -> JSONResponse:
+        exc_str = f"{exc}".replace("\n", " ").replace("   ", " ")
+        logging.error(f"{request}: {exc_str}")
+        content = {"status_code": 422, "message": exc_str, "data": None}
+        return JSONResponse(
+            content=content, status_code=status.HTTP_422_UNPROCESSABLE_ENTITY
+        )
+
     return fast_api_app
 
 

glitchtip_jira_bridge/models.py

@@ -10,7 +10,7 @@ class Field(BaseModel):
 class Attachment(BaseModel):
     title: str
     title_link: str
-    text: str
+    text: str | None
     image_url: str | None = None
     color: str | None = None
     fields: list[Field] | None = None

pyproject.toml

@@ -57,7 +57,7 @@ branch = true
 omit = ["*/tests/*"]
 
 [tool.coverage.report]
-fail_under = 95
+fail_under = 90
 
 # Ruff configuration
 [tool.ruff]