⚡ slack-usergroups: performance fix #4800
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patjlm
reviewed
Dec 17, 2024
| repo_tree = self._git_cli.get_repository_tree(ref=self._ref) | ||
| owner_files = [item for item in repo_tree if item["name"] == "OWNERS"] | ||
| else: | ||
| owner_files = [{"path": "OWNERS"}] |
There was a problem hiding this comment.
what happens if there is no such file? Won't we raise an exception later?
There was a problem hiding this comment.
I thought the same, but gitlab_api and github_api ignore any missing files. Nevertheless, I've added a warning in 1508ec and fixed an attribute error a long the way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't download the complete git repo file list.
slack-usergroupsuses just the root level (.)OWNERSfile but downloads a list of all files from the git repos. clusterimagesets has more than 31000 files,get_repository_treereceives the file catalog in 100 chunks. In total, ~310 HTTP requests, and each takes 1 second.This fix reduces the runtime of a reconciliation loop by 6 minutes.