feat: add mobile:webInspector to send webinspector command#1619
Closed
feat: add mobile:webInspector to send webinspector command#1619
Conversation
jlipps
reviewed
Apr 18, 2023
Member
jlipps
left a comment
There was a problem hiding this comment.
cool idea! why call it 'web inspector' and not something more like 'sendRemoteDebugCommand'? i'm unclear what it has to do with the web inspector
Member
Author
|
That was just picked from |
Member
Author
|
closing as this was an experimental idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of #1455
I haven't tested yet, but I'd like to do somehing laster:
Animation.enable,Animation.disableApplicationCache.enable,ApplicationCache.disableDOMStorage.enable,DOMStorage.disableMemory.enable,Memory.disableNetwork.setEmulatedConditionsPerhaps this pr needs to have some documentation with a couple of example code.
I'm thinking to add this command to send some of webinspector commands
https://github.com/appium/appium-remote-debugger/blob/717a6310dba7ccf14db8aeef28b8eac3d7f6abf9/lib/protocol/index.js
Maybe it does not work fully, so we may need to append more code, or need to update the remote debugger side such as https://github.com/appium/appium-remote-debugger/blob/717a6310dba7ccf14db8aeef28b8eac3d7f6abf9/lib/rpc/remote-messages.js#L13.
example usage: