Pd 1635 remove deprecated dast apis#1518
Conversation
WalkthroughThis pull request removes a range of deprecated files and legacy code across adapters, components, models, serializers, styles, and tests related to device preferences and dynamic scanning. Outdated URL builders, computed properties, and enum references (now replaced with DS_DEVICE_TYPE) are eliminated. The changes also update Mirage API routes and remove unnecessary endpoints from environment configuration, resulting in a leaner codebase with fewer legacy registrations and redundant logic. Changes
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
npm warn config production Use 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (25)
💤 Files with no reviewable changes (21)
🚧 Files skipped from review as they are similar to previous changes (4)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying irenestaging with
|
| Latest commit: |
8129d01
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2ccec335.irenestaging.pages.dev |
| Branch Preview URL: | https://pd-1635-remove-deprecated-da.irenestaging.pages.dev |
Irene
|
||||||||||||||||||||||||||||||||||
| Project |
Irene
|
| Branch Review |
PD-1635-remove-deprecated-dast-apis
|
| Run status |
|
| Run duration | 05m 12s |
| Commit |
|
| Committer | Avi Shah |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
1
|
|
|
0
|
|
|
0
|
|
|
1
|
|
|
30
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/tests/dynamic-scan.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Dynamic Scan > it tests dynamic scan for an apk file: 58062 |
Test Replay
Screenshots
|
|
98ab577 to
e54de0c
Compare
e54de0c to
5a455b6
Compare
5a455b6 to
52f63d0
Compare
|
52f63d0 to
00c8380
Compare
00c8380 to
3fe67c7
Compare
3fe67c7 to
ed01ac3
Compare
ed01ac3 to
6564dfe
Compare
6564dfe to
f48653c
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
mirage/config.js (2)
436-438: Add mock response data for DELETE dynamicscans endpoint.The endpoint returns an empty object. Consider adding mock response data to better simulate the API behavior.
this.delete('/v2/dynamicscans/:id', () => { - return {}; + return { + status: 'success', + message: 'Dynamic scan deleted successfully' + }; });
440-442: Add mock response data for PUT dynamicscans extend endpoint.The endpoint returns an empty object. Consider adding mock response data to better simulate the API behavior.
this.put('/v2/dynamicscans/:id/extend', () => { - return {}; + return { + status: 'success', + message: 'Dynamic scan extended successfully', + extended_until: new Date(Date.now() + 24 * 60 * 60 * 1000).toISOString() + }; });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (43)
app/adapters/device-preference.ts(0 hunks)app/adapters/dynamicscan-mode.ts(0 hunks)app/adapters/dynamicscan-old.ts(0 hunks)app/adapters/project-available-device.ts(2 hunks)app/components/file-details/dynamic-scan/action/drawer/device-pref-table/type/index.ts(1 hunks)app/components/file-details/dynamic-scan/drawer-old/index.hbs(0 hunks)app/components/file-details/dynamic-scan/drawer-old/index.scss(0 hunks)app/components/file-details/dynamic-scan/drawer-old/index.ts(0 hunks)app/components/file-details/dynamic-scan/drawer-old/proxy-settings-view/index.hbs(0 hunks)app/components/file-details/dynamic-scan/drawer-old/proxy-settings-view/index.scss(0 hunks)app/components/file-details/dynamic-scan/drawer-old/proxy-settings-view/index.ts(0 hunks)app/components/file-details/dynamic-scan/expiry-old/index.hbs(0 hunks)app/components/file-details/dynamic-scan/expiry-old/index.scss(0 hunks)app/components/file-details/dynamic-scan/expiry-old/index.ts(0 hunks)app/components/file-details/scan-actions-old/manual-scan/index.scss(0 hunks)app/components/project-preferences-old/device-preference/index.hbs(0 hunks)app/components/project-preferences-old/device-preference/index.ts(0 hunks)app/components/project-preferences-old/index.hbs(0 hunks)app/components/project-preferences-old/index.ts(0 hunks)app/components/project-preferences-old/provider/index.hbs(0 hunks)app/components/project-preferences-old/provider/index.ts(0 hunks)app/enums.ts(0 hunks)app/models/device-preference.ts(0 hunks)app/models/dynamicscan-mode.ts(0 hunks)app/models/dynamicscan-old.ts(0 hunks)app/models/file.ts(0 hunks)app/serializers/device-preference.js(0 hunks)app/styles/_component-variables.scss(0 hunks)config/environment.js(0 hunks)mirage/config.js(1 hunks)mirage/factories/device-preference.ts(0 hunks)mirage/factories/file.ts(0 hunks)mirage/factories/project.ts(1 hunks)tests/acceptance/file-details-test.js(1 hunks)tests/acceptance/file-details/api-scan-test.js(0 hunks)tests/acceptance/file-details/manual-scan-test.js(0 hunks)tests/integration/components/file-details/dynamic-scan/manual-test.js(3 hunks)tests/integration/components/file-details/scan-actions/api-scan-test.js(0 hunks)tests/unit/adapters/dynamicscan-mode-test.js(0 hunks)tests/unit/helpers/device-type-test.js(1 hunks)tests/unit/models/device-preference-test.js(0 hunks)tests/unit/models/dynamicscan-mode-test.js(0 hunks)tests/unit/models/file-test.js(0 hunks)
💤 Files with no reviewable changes (36)
- mirage/factories/file.ts
- tests/unit/adapters/dynamicscan-mode-test.js
- tests/integration/components/file-details/scan-actions/api-scan-test.js
- app/components/project-preferences-old/provider/index.hbs
- app/components/file-details/dynamic-scan/expiry-old/index.scss
- app/adapters/device-preference.ts
- tests/unit/models/dynamicscan-mode-test.js
- tests/unit/models/device-preference-test.js
- tests/acceptance/file-details/api-scan-test.js
- tests/acceptance/file-details/manual-scan-test.js
- app/serializers/device-preference.js
- app/components/file-details/dynamic-scan/drawer-old/index.hbs
- app/components/file-details/dynamic-scan/drawer-old/proxy-settings-view/index.hbs
- app/components/file-details/dynamic-scan/drawer-old/proxy-settings-view/index.scss
- app/components/file-details/dynamic-scan/drawer-old/index.scss
- config/environment.js
- app/models/dynamicscan-mode.ts
- app/adapters/dynamicscan-old.ts
- app/components/file-details/dynamic-scan/expiry-old/index.hbs
- app/components/project-preferences-old/device-preference/index.hbs
- app/models/dynamicscan-old.ts
- app/components/file-details/scan-actions-old/manual-scan/index.scss
- app/enums.ts
- app/adapters/dynamicscan-mode.ts
- app/components/file-details/dynamic-scan/drawer-old/proxy-settings-view/index.ts
- app/styles/_component-variables.scss
- app/models/device-preference.ts
- tests/unit/models/file-test.js
- app/components/project-preferences-old/provider/index.ts
- mirage/factories/device-preference.ts
- app/components/project-preferences-old/index.hbs
- app/components/file-details/dynamic-scan/drawer-old/index.ts
- app/components/project-preferences-old/index.ts
- app/components/project-preferences-old/device-preference/index.ts
- app/components/file-details/dynamic-scan/expiry-old/index.ts
- app/models/file.ts
🚧 Files skipped from review as they are similar to previous changes (6)
- app/components/file-details/dynamic-scan/action/drawer/device-pref-table/type/index.ts
- mirage/factories/project.ts
- tests/unit/helpers/device-type-test.js
- tests/integration/components/file-details/dynamic-scan/manual-test.js
- app/adapters/project-available-device.ts
- tests/acceptance/file-details-test.js
⏰ Context from checks skipped due to timeout of 90000ms (12)
- GitHub Check: Run Integration Tests - Part 8
- GitHub Check: Run Integration Tests - Part 7
- GitHub Check: Run Integration Tests - Part 6
- GitHub Check: Run Integration Tests - Part 5
- GitHub Check: Run Integration Tests - Part 4
- GitHub Check: Run Integration Tests - Part 3
- GitHub Check: Run Integration Tests - Part 2
- GitHub Check: Run Integration Tests - Part 1
- GitHub Check: Run Acceptance Tests
- GitHub Check: Run Unit Tests
- GitHub Check: Run Linting
- GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
mirage/config.js (1)
28-28: LGTM! Good API versioning practice.The v2 API endpoints are properly grouped together as noted in the comment, maintaining a clean and organized structure.
Also applies to: 432-442
f48653c to
b7ab49b
Compare
b7ab49b to
a9959f9
Compare
a9959f9 to
a67b57a
Compare
a67b57a to
0a4f02b
Compare
0a4f02b to
8129d01
Compare
|



No description provided.